Skip to content

Commit

Permalink
Improve --dry-run with legacy resolver
Browse files Browse the repository at this point in the history
  • Loading branch information
sbidoul committed May 30, 2022
1 parent 7cdc1aa commit 183e47f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/pip/_internal/commands/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,9 @@ def run(self, options: Values, args: List[str]) -> int:
if options.dry_run:
would_install_items = sorted(
(r.metadata["name"], r.metadata["version"])
for r in requirement_set.all_requirements
# Use get_installation_order because it does some important
# filtering with the legacy resolver.
for r in resolver.get_installation_order(requirement_set)
)
if would_install_items:
write_output(
Expand Down

0 comments on commit 183e47f

Please sign in to comment.