Skip to content

Commit

Permalink
Reduce resolver rounds by an order of magnitude (#11908)
Browse files Browse the repository at this point in the history
Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
  • Loading branch information
pradyunsg and pradyunsg authored Mar 29, 2023
1 parent 28239f9 commit 10d9cbc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions news/11908.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reduce the number of resolver rounds, since backjumping makes the resolver more efficient in finding solutions. This also makes pathological cases fail quicker.
4 changes: 2 additions & 2 deletions src/pip/_internal/resolution/resolvelib/resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ def resolve(
)

try:
try_to_avoid_resolution_too_deep = 2000000
limit_how_complex_resolution_can_be = 200000
result = self._result = resolver.resolve(
collected.requirements, max_rounds=try_to_avoid_resolution_too_deep
collected.requirements, max_rounds=limit_how_complex_resolution_can_be
)

except ResolutionImpossible as e:
Expand Down

0 comments on commit 10d9cbc

Please sign in to comment.