use ensurepip, other small cleanups #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattip
commented
Mar 19, 2020
mattip
commented
- document quay.io/organization/pypa for easy reference
- remove 3.4 from the documents
- replace get-pip with ensurepip
- add a hash for wheel
- pin python2.7 requirements since setuptools 46 doesn't support it xref Bump setuptools from 43.0.0 to 46.0.0 in /docker/build_scripts #491)
auvipy
reviewed
Mar 19, 2020
docker/build_scripts/build_utils.sh
Outdated
| @@ -54,14 +54,18 @@ function do_cpython_build { | |||
| if [ -e ${prefix}/bin/python3 ]; then | |||
| ln -s python3 ${prefix}/bin/python | |||
| fi | |||
| ${prefix}/bin/python get-pip.py | |||
| ${prefix}/bin/python -mensurepip | |||
There was a problem hiding this comment.
why? Both -mensurepip and -m ensurepip work.
There was a problem hiding this comment.
I see. Yes, but the second one is more readable.
auvipy
approved these changes
Mar 20, 2020
|
What is the proper git incantation to merge this to manylinux2014? Do we merge the branch into manylinux2014 or cherry-pick the commits? |
|
@mattip, that would be cherry-picking the commits. |
mattip
added a commit
to mattip/manylinux
that referenced
this pull request
Mar 23, 2020
auvipy
pushed a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.