Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project falling behind on best practices #210

Closed
jaraco opened this issue Jul 1, 2023 · 2 comments · Fixed by #217
Closed

project falling behind on best practices #210

jaraco opened this issue Jul 1, 2023 · 2 comments · Fixed by #217

Comments

@jaraco
Copy link
Member

jaraco commented Jul 1, 2023

Unlike other projects I maintain, this project, because it hasn't been managed as a PyPI-released package, has had its project practices incorporated ad hoc from other projects. This situation means that the CI configuration and linting techniques and other factors are falling behind those maintained at jaraco/skeleton.

This project should probably adopt jaraco/skeleton even if it's not going to be released on PyPI.

@jaraco jaraco closed this as completed in 43a08f1 Jul 1, 2023
@jaraco jaraco reopened this Jul 2, 2023
@jaraco
Copy link
Member Author

jaraco commented Jul 2, 2023

Although the tests were passing locally, pushing 43a08f1 to main caused tests to fail on collection discovery (first error was no module named "distutils._collections", suggesting that something is masking the install of distutils.

@jaraco
Copy link
Member Author

jaraco commented Nov 5, 2023

Although the tests were passing locally, pushing 43a08f1 to main caused tests to fail on collection discovery (first error was no module named "distutils._collections", suggesting that something is masking the install of distutils.

These issues appear to no longer be a concern. Tests are now passing except on Python 3.12, where they are failing locally and remotely due to the lack of Setuptools (https://github.com/pypa/distutils/actions/runs/6762381796/job/18378289201) now that Python's test.support module relies on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant