Inline dependency-versions syntax #2122
Conversation
|
Having reviewed #2002 again, I think this would be a useful feature. Specifically, there's a check for compatible versions between pyodide and pyodide-build - if we provide an option for CIBW_PYODIDE_VERSION, and we don't have this, changing pyodide version becomes a bit hassle, because you need to make a constraints file as well. |
joerick
force-pushed
the
dependency-version-inline
branch
from
1912c7a to
870a1dd
Compare
for more information, see https://pre-commit.ci
|
This should be ready to go, pending review. |
|
Two questions:
|
|
I've managed to make some conflicts due to #2276. I can rebase if you prefer, sorry! |
Good point. I think that should be equivalent to 'latest', as in it pins nothing. I'll make sure that's covered with a test case.
It doesn't inherit. I considered including it but because of the backwards-compatibility requirements1 it's awkward to implement (the syntax is different from the other table-style options). Also, I couldn't think of a situation it might be useful. What do you think? Footnotes
|
And, remove some optionals to reduce the problem space
…line # Conflicts: # cibuildwheel/options.py # cibuildwheel/util/packaging.py # test/test_dependency_versions.py # unit_test/dependency_constraints_test.py
|
This is ready for another review, the empty packages case is now covered. |
To help with #2002, I propose a way to specify dependency version constraints inline, without the extra file. This would eliminate the need for an additional CIBW_PYODIDE_BUILD_VERSION option, while being consistent with our existing version management system.
This would allow setting the pyodide-build version like:
So far, no implementation yet, just docs for discussion.