Skip to content

Commit 84b6ff4

Browse files
authored
Resolve pylint R1705 (#170)
1 parent 0cbd64c commit 84b6ff4

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

pytest_pyodide/decorator.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,8 @@ def __new__(cls, function: Callable[..., Any] | None = None, /, **kwargs):
372372
# def f():
373373
# pass
374374
return run_in_pyodide(**kwargs)(function)
375-
else:
376-
# Just do normal __new__ behavior
377-
return object.__new__(cls)
375+
# Just do normal __new__ behavior
376+
return object.__new__(cls)
378377

379378
def __init__(
380379
self,

pytest_pyodide/run_tests_inside_pyodide.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ def _remove_pytest_capture_title(
106106
ret_data = "\n".join(lines[1:])
107107
if re.search(r"\S", ret_data):
108108
return ret_data
109-
else:
110-
return None
109+
return None
111110

112111

113112
def run_test_in_pyodide(node_tree_id, selenium, ignore_fail=False):

pytest_pyodide/runner.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,8 @@ def run_js_inner(self, code, check_code):
363363
retval = self.driver.execute_async_script(wrapper % (code, check_code))
364364
if retval[0] == 0:
365365
return retval[1]
366-
else:
367-
print("JavascriptException message: ", retval[3])
368-
raise JavascriptException(retval[1], retval[2])
366+
print("JavascriptException message: ", retval[3])
367+
raise JavascriptException(retval[1], retval[2])
369368

370369
@property
371370
def urls(self):
@@ -416,8 +415,7 @@ def run_js_inner(self, code, check_code):
416415
retval = self.driver.evaluate(wrapper % (code, check_code))
417416
if retval[0] == 0:
418417
return retval[1]
419-
else:
420-
raise JavascriptException(retval[1], retval[2])
418+
raise JavascriptException(retval[1], retval[2])
421419

422420

423421
class SeleniumFirefoxRunner(_SeleniumBaseRunner):
@@ -643,5 +641,4 @@ def run_js_inner(self, code, check_code):
643641
self.p.expect_exact(f"\r\n{cmd_id}:UUID\r\n")
644642
if success:
645643
return json.loads(self.p.before.decode().replace("undefined", "null"))
646-
else:
647-
raise JavascriptException("", self.p.before.decode())
644+
raise JavascriptException("", self.p.before.decode())

pytest_pyodide/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ def parse_driver_timeout(node) -> float | None:
2828
mark = node.get_closest_marker("driver_timeout")
2929
if mark is None:
3030
return None
31-
else:
32-
return mark.args[0] # type: ignore[no-any-return]
31+
return mark.args[0] # type: ignore[no-any-return]
3332

3433

3534
def parse_xfail_browsers(node) -> dict[str, str]:

0 commit comments

Comments
 (0)