Handle duplicate widget names when joining PDFs #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in some constellations duplicated fields on source pages (i.e. having a common parent) were not correctly copied over to the target PDF. In addition, when source widgets happened to have same names as present in the target, invalid widgets resulted in the merged PDF. This fix copies all root widgets to the target in a separate first step. Only any root fields in source pages are separately copied over. Finally, name duplicates are resolved by either renaming source widgets, or (option) joining them with target widgets in common `/Kids` arrays.
JorjMcKie
force-pushed
the
improve-field-mergers
branch
from
2862ce9 to
29fac61
Compare
julian-smith-artifex-com
approved these changes
Mar 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in some constellations duplicated fields on source pages (i.e. having a common parent) were not correctly copied over to the target PDF. In addition, when source widgets happened to have same names as present in the target, invalid widgets resulted in the merged PDF.
This fix copies all root widgets to the target in a separate first step. Only any root fields in source pages are separately copied over.
Finally, name duplicates are resolved by either renaming source widgets, or (option) joining them with target widgets in common
/Kidsarrays.