Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform matrix of get_image_bbox() does not always detect image mirroring #1244

Closed
JorjMcKie opened this issue Sep 6, 2021 · 1 comment
Assignees
Labels

Comments

@JorjMcKie
Copy link
Collaborator

JorjMcKie commented Sep 6, 2021

Please provide all mandatory information!

Describe the bug (mandatory)

The algorithm computing the image transformation matrix in page.get_image_bbox() will not always correctly reflect whether an image has been flipped (left-right or top-bottom).
This only affects the matrix returned by page.get_image_bbox(item, transform=True). The bbox itself is correct.
Also refer to discussion #1217.

To Reproduce (mandatory)

Explain the steps to reproduce the behavior, For example, include a minimal code snippet, example files, etc.

Expected behavior (optional)

Describe what you expected to happen (if not obvious).

Screenshots (optional)

If applicable, add screenshots to help explain your problem.

Your configuration (mandatory)

Affects all platforms.

Additional context (optional)

As an intermediate solution, page.get_image_rects(item, transform=True)[0] can be used. This should deliver the correct transformation matrix.
In the next version, this intermediate solution will replace the original.

@JorjMcKie JorjMcKie added the bug label Sep 6, 2021
@JorjMcKie JorjMcKie self-assigned this Sep 6, 2021
@JorjMcKie
Copy link
Collaborator Author

new version 1.18.18 now on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant