How to log connected client IP addresses

[Beetix]

Hi,

I used to be able to log the connecting clients IP address in version 3.8.2 with the following code:

from pymodbus.server.async_io import ModbusServerRequestHandler

def connection_made_patched(self, transport) -> None:
        Log.info("Connected to {}", transport.get_extra_info('peername'))
        self.transport = transport
        self.reset_delay()
        self.callback_connected()

ModbusServerRequestHandler.connection_made = connection_made_patched

I'm facing some bugs and I would like to upgrade to newest version 3.11.4. The library's code has changed quite a bit since then and this snippet doesn't work anymore. I've looked into the trace_xxx callback but they don't seem to carry the needed information.

Is there a way to achieve this in version 3.11.4?

Thank you in advance

[janiversen]

As far as I know, the server side code have only had minor changes, and the transport layer have only had a few bug fixes.

You are patching into the internal parts of the code, and even though not recomendad, you can do a similar thing in 3.11.4

the proper way to do this is however to use the trace hooks. The trace functions most likely will not have the information you seen, but they are called at the right places and supported. In the function itself you can do as you do in your current patch.

[Beetix]

I understand that it was more a hack than a long term solution yes.

Regarding the trace hooks I've tried trace_connect but it's seems that the only parameter given is a boolean representing a connection or disconnection. How would I get access to the IP address of the client from there?

[janiversen]

As I wrote the parameters is not what you need, but it is called when a connection is made, and in the function you can e.g. examine transport, just like you did im your hack.