Replies: 2 comments
-
|
Sounds correct. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Done #2835 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The function ModbusServerContext.device_ids() is documented as following:
pymodbus/pymodbus/datastore/context.py
Lines 225 to 227 in 886632a
But the function returns the configured device ids. I am not sure about the word "Define", because when I read the documentation, I first though we could declare some more devices with this function.
It is just to be sure... Shouldn't the docstring be changed into
Get the configured device ids?I can do the PR, that's no big deal, I just wanted to ask first.
Beta Was this translation helpful? Give feedback.
All reactions