better fix for rtu incomplete frames (#511)

* better fix for rtu incomplete frames

- avoid multiple calls to populateHeader()
- trap IndexError in calculateRtuFrameSize()
- more readable

Co-authored-by: jan Iversen <jancasacondor@gmail.com>

Author: sherpya

examples/contrib/message_parser.py

@@ -105,7 +105,7 @@ def report(self, message):  # pylint: disable=no-self-use
                         "  %-12s => %s" % (k_item, v_item)  # pylint: disable=consider-using-f-string
                     )
 
-            elif isinstance(v_dict, collections.Iterable):  # pylint: disable=no-member
+            elif isinstance(v_dict, collections.Iterable):
                 print("%-15s =" % k_dict)  # pylint: disable=consider-using-f-string
                 value = str([int(x) for x in v_dict])
                 for line in textwrap.wrap(value, 60):

pymodbus/framer/rtu_framer.py

@@ -131,18 +131,17 @@ def isFrameReady(self):
 
         :returns: True if ready, False otherwise
         """
-        if len(self._buffer) <= self._hsize:
-            return False
-
-        try:
-            # Frame is ready only if populateHeader() successfully
-            # populates crc field which finishes RTU frame otherwise,
-            # if buffer is not yet long enough, populateHeader() raises IndexError
-            self.populateHeader()
-        except IndexError:
-            return False
-
-        return True
+        size = self._header.get('len', 0)
+        if not size and len(self._buffer) > self._hsize:
+            try:
+                # Frame is ready only if populateHeader() successfully
+                # populates crc field which finishes RTU frame otherwise,
+                # if buffer is not yet long enough, populateHeader() raises IndexError
+                size = self.populateHeader()
+            except IndexError:
+                return False
+
+        return len(self._buffer) >= size if size > 0 else False
 
     def populateHeader(self, data=None):  # pylint: disable=invalid-name
         """Try to set the headers `uid`, `len` and `crc`.
@@ -164,6 +163,7 @@ def populateHeader(self, data=None):  # pylint: disable=invalid-name
             # crc yet not available
             raise IndexError
         self._header["crc"] = data[size - 2 : size]
+        return size
 
     def addToFrame(self, message):
         """Add the received data to the buffer handle.