Skip to content

Commit 20a3001

Browse files
Fix linting and tests.
1 parent 63d7fc0 commit 20a3001

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.github/workflows/pyleco_CI.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
- name: Lint with ruff
3030
uses: chartboost/ruff-action@v1
3131
with:
32+
version: 0.4.10 # ruff-action@v1 is broken in regard to ruff 0.5.0
3233
args: --extend-select=E9,F63,F7,F82 --show-source
3334
- uses: ammaraskar/sphinx-problem-matcher@master
3435
- name: Generate docs

tests/acceptance_tests/test_director_actor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def test_data_via_control_protocol(director: Director):
177177
director.ask_rpc("register_subscriber")
178178
director.ask_rpc("publish")
179179

180-
msg = director.communicator.read_message()
180+
msg = director.communicator.read_message(conversation_id=None)
181181
director.communicator.send(
182182
receiver=director.actor, # type: ignore
183183
data={"jsonrpc": "2.0", "id": 1, "result": None},

tests/utils/test_extended_data_publisher.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232

3333
CID = b"conversation_id;"
34-
34+
messages = [] # for tests
3535

3636
@pytest.fixture
3737
def fake_send_message():
@@ -86,7 +86,8 @@ def test_unregister_subscribers(publisher: ExtendedDataPublisher):
8686
@pytest.mark.parametrize("receivers", (set(), {b"abc"}, {b"abc", b"def"}, {"string"}))
8787
def test_convert(publisher: ExtendedDataPublisher, receivers, data_message: DataMessage):
8888
msgs = publisher.convert_data_message_to_messages(data_message, receivers=receivers)
89-
for rec, msg in zip(receivers, msgs, strict=True):
89+
assert len(receivers) == len(list(msgs)), "The lengths of receivers and messages do not match."
90+
for rec, msg in zip(receivers, msgs):
9091
assert msg == Message(
9192
receiver=rec,
9293
data={"id": 1, "method": "set_subscription_message", "jsonrpc": "2.0"},

tests/utils/test_extended_message_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737

3838
CID = b"conversation_id;"
39-
39+
_data = None # for temporary storage
4040

4141
@pytest.fixture
4242
def handler():

0 commit comments

Comments
 (0)