Fix tests

Author: BenediktBurger

pyleco/json_utils/errors.py

@@ -71,6 +71,8 @@
 class JSONRPCError(Exception):
     """Base error that all JSON RPC exceptions extend."""
 
+    rpc_error: JsonRpcError
+
     def __init__(self, error: JsonRpcError) -> None:
         msg = f"{error.code}: {error.message}"
         self.rpc_error = error

pyleco/utils/extended_data_publisher.py

@@ -91,7 +91,7 @@ def handle_json_error(self, message: Message) -> None:
         except JSONRPCError as exc:
             error_code = exc.rpc_error.code
             try:
-                error_data = exc.rpc_error.data
+                error_data = exc.rpc_error.data  # type: ignore
             except AttributeError:
                 return
             if error_code == RECEIVER_UNKNOWN:

tests/acceptance_tests/test_director_actor.py

@@ -29,7 +29,6 @@
 
 import pytest
 
-from pyleco.core.message import MessageTypes
 from pyleco.coordinators.coordinator import Coordinator
 from pyleco.actors.actor import Actor
 from pyleco.directors.director import Director
@@ -178,15 +177,9 @@ def test_data_via_control_protocol(director: Director):
     director.ask_rpc("publish")
 
     msg = director.communicator.read_message(conversation_id=None)
-    director.communicator.send(
-        receiver=director.actor,  # type: ignore
-        data={"jsonrpc": "2.0", "id": 1, "result": None},
-        conversation_id=msg.conversation_id,
-        message_type=MessageTypes.JSON,
-    )
 
     # teardown
     director.ask_rpc("unregister_subscriber")
 
-    assert msg.data == {"jsonrpc": "2.0", "id": 1, "method": "add_subscription_message"}
+    assert msg.data == {"jsonrpc": "2.0", "method": "add_subscription_message"}
     assert msg.payload[1:] == [b'super content']

tests/utils/test_extended_data_publisher.py

@@ -86,8 +86,9 @@ def test_unregister_subscribers(publisher: ExtendedDataPublisher):
 
 @pytest.mark.parametrize("receivers", (set(), {b"abc"}, {b"abc", b"def"}, {"string"}))
 def test_convert(publisher: ExtendedDataPublisher, receivers, data_message: DataMessage):
-    msgs = publisher.convert_data_message_to_messages(data_message, receivers=receivers)
-    for rec, msg in zip(receivers, msgs, strict=True):
+    msgs = list(publisher.convert_data_message_to_messages(data_message, receivers=receivers))
+    assert len(msgs) == len(receivers)
+    for rec, msg in zip(receivers, msgs):
         assert msg == Message(
             receiver=rec,
             data=Notification(method="add_subscription_message"),