Skip to content

Add full_like, ones_like, and zeros_like for XTensorVariable #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

Add full_like, ones_like, and zeros_like for XTensorVariable #1514

merged 3 commits into from
Jul 2, 2025

Conversation

AllenDowney
Copy link
Contributor

@AllenDowney AllenDowney commented Jul 1, 2025 •
edited by github-actions bot
Loading

@ricardoV94 please take a look

📚 Documentation preview 📚: https://pytensor--1514.org.readthedocs.build/en/1514/

ricardoV94
ricardoV94 reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good just one check missing and test questions

ricardoV94
ricardoV94 reviewed Jul 2, 2025
View reviewed changes
@AllenDowney AllenDowney changed the title First pass at full_like, ones_like, and zeros_like Add full_like, ones_like, and zeros_like for XTensorVariable Jul 2, 2025
@AllenDowney
Copy link
Contributor Author

@ricardoV94 I think this is ready for another look

ricardoV94
ricardoV94 reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last request, not to have too much going on in the math module, since these operations aren't really mathematical, they just happen to use an op defined there.

ricardoV94
ricardoV94 requested changes Jul 2, 2025
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah saw something on the docs

@ricardoV94 ricardoV94 added enhancement New feature or request xtensor labels Jul 2, 2025
@ricardoV94 ricardoV94 merged commit 5296a80 into pymc-devs:labeled_tensors Jul 2, 2025
5 checks passed
@ricardoV94
Copy link
Member

Thanks a ton @AllenDowney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request xtensor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllenDowney @ricardoV94