Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in implicit_size_from_params #7564

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 7, 2024

Also avoids some deprecation warnings in a separate commit


📚 Documentation preview 📚: https://pymc--7564.org.readthedocs.build/en/7564/

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (3057351) to head (d2215d4).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7564   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         106      106           
  Lines       17669    17669           
=======================================
  Hits        16403    16403           
  Misses       1266     1266           
Files with missing lines Coverage Δ
pymc/distributions/continuous.py 98.25% <ø> (ø)
pymc/distributions/moments/means.py 100.00% <100.00%> (ø)
pymc/distributions/shape_utils.py 90.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit f551718 into pymc-devs:main Nov 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants