Return InferenceData when there are no variables sampled and extend=True #7509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are no variables to sample and
extend_inferencedata=True
the returned objectis
trace
at that point in the code which in the common case of providing an InferenceDatato sample_posterior_predictive is only its posterior group. Consequently:
This PR changes the behaviour so
idata
above continues to be the providedidata
and addsa test for it.
Related Issue
I considered it was easier to open the PR directly instead of first issue then PR.
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7509.org.readthedocs.build/en/7509/