Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spurious deprecation warning in CustomDist #7391

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 25, 2024

Description

The warning is causing the CI in pymc-experimental to fail pymc-devs/pymc-experimental#352

Also allow multivariate CustomDist to be created when signature suffices to infer core shape.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7391.org.readthedocs.build/en/7391/

…stomDist

Also allow multivariate CustomDist to be created when signature suffices to infer core shape.
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (b496127) to head (b2f3c48).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7391   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         103      103           
  Lines       17214    17208    -6     
=======================================
- Hits        15870    15865    -5     
+ Misses       1344     1343    -1     
Files with missing lines Coverage Δ
pymc/distributions/custom.py 95.54% <100.00%> (+1.08%) ⬆️

... and 1 file with indirect coverage changes

@ricardoV94 ricardoV94 merged commit d4e5db1 into pymc-devs:main Jun 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants