Add more idata attributes for JAX samplers #7360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
osyuksel
changed the title
ricardoV94
reviewed
Jun 16, 2024
ricardoV94
reviewed
Jun 16, 2024
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
|
Added trailing commas for formatting. |
twiecki
approved these changes
Jun 16, 2024
ricardoV94
reviewed
Jun 17, 2024
| @@ -44,6 +44,10 @@ def test_external_nuts_sampler(recwarn, nuts_sampler): | |||
| idata1 = sample(**kwargs) | |||
| idata2 = sample(**kwargs) | |||
There was a problem hiding this comment.
Not introduced by you, but why are we sampling twice, is idata2 used anywhere?
osyuksel
commented
Jun 17, 2024
| @@ -64,8 +68,11 @@ def test_external_nuts_sampler(recwarn, nuts_sampler): | |||
| assert "L" in idata1.observed_data | |||
| assert idata1.posterior.chain.size == 2 | |||
| assert idata1.posterior.draw.size == 500 | |||
| assert idata1.posterior.tuning_steps == 500 | |||
| np.testing.assert_array_equal(idata1.posterior.x, idata2.posterior.x) | |||
There was a problem hiding this comment.
@ricardoV94 idata2 is used in this line only, to check if the sampling is deterministic I think?
There was a problem hiding this comment.
Ah okay! Thanks for checking
ricardoV94
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a fix for #7262 by filling in missing
post_ attributeskeyword argument.Related Issue
Checklist
Type of change