-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in compute_log_likelihood
when variable has dims without coords
#6882
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6882 +/- ##
==========================================
- Coverage 92.16% 92.16% -0.01%
==========================================
Files 100 100
Lines 16841 16839 -2
==========================================
- Hits 15521 15519 -2
Misses 1320 1320
|
Thanks @jaharvey8. Can you add a small test that was triggering the error before this fix? |
Sure, I hate to ask an annoying question, but what's the best format for uploading a test? Or is there documentation somewhere on uploading tests? |
Not annoying at all. There should some tests in To run the tests locally check this guide: https://www.pymc.io/projects/docs/en/latest/contributing/running_the_test_suite.html If you have any questions, just ask away! |
compute_log_likelihood
when variable has dims without coords
1a338ce
to
8a0cbfb
Compare
@jaharvey8 I refactored a bit the code to avoid duplication and added a test. Let me know if it looks good on your end. |
e3cea7a
to
ed631a2
Compare
ed631a2
to
6e96bf4
Compare
Bugfixes
Fixes #6820
📚 Documentation preview 📚: https://pymc--6882.org.readthedocs.build/en/6882/