[MAINT] Fix for #3346 #3352
Merged
[MAINT] Fix for #3346 #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the name of a variable was in the supplied point, then the value for said variable would be taken from the point dictionary. This was too permissive, and different from what was done in _draw_value. There, the value could be taken from the point dictionary only if the variable had the attribute model, i.e. it was an RV instance instead of a Deterministic.
Member
Author
|
@junpenglao, @ColCarroll, @twiecki, do you think it is ok that |
ColCarroll
reviewed
Jan 24, 2019
Member
ColCarroll
left a comment
ColCarroll
left a comment
There was a problem hiding this comment.
the test makes this look like a good change, but I have trouble figuring out what was wrong and how this code fixes it! i'll keep looking at it, but would appreciate some pointers!
Member
|
Regarding your question, I think it should definitely ignore any Deterministics in the point argument. You could do really weird stuff otherwise. |
…meters to get their values from the point dictionary.
Member
|
Thanks for these very technical fixes, @lucianopaz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3346. The
draw_valuesfunction had a statement that said that if the name of a variable was in the suppliedpoint, then the value for said variable would be taken from thepointdictionary. This was too permissive, and different from what was done in_draw_value. There, the value could be taken from thepointdictionary only if the variable had the attributemodel, i.e. it was an RV instance instead of aDeterministic.The downside of this PR is that we cannot force values to
Deterministics insample_posterior_predictiverelying on thepointparameter.