Improve docstrings in _combine_property

Author: AlexAndorra

pymc_extras/statespace/models/structural/core.py

@@ -784,22 +784,21 @@ def _combine_property(self, other, name, allow_duplicates=True):
             new_prop.update(other_prop)
             return new_prop
         else:
-            # NEW: Handle cases where self_prop is not a list or dict
-            import numpy as np
+            # handle cases where self_prop is not a list or dict
 
-            # Handle numpy arrays specially
+            # handle numpy arrays specifically
             if isinstance(self_prop, np.ndarray) and isinstance(other_prop, np.ndarray):
                 if np.array_equal(self_prop, other_prop):
                     return self_prop
                 else:
-                    # Convert to list for combination when arrays are different
+                    # convert to list for combination when arrays are different
                     return (
                         list(self_prop) + [x for x in other_prop if x not in self_prop]
                         if not allow_duplicates
                         else list(self_prop) + list(other_prop)
                     )
             elif isinstance(self_prop, np.ndarray) or isinstance(other_prop, np.ndarray):
-                # One is array, one is not - convert to list
+                # one is array, one is not - convert to list
                 self_list = (
                     list(self_prop)
                     if isinstance(self_prop, np.ndarray)
@@ -826,7 +825,8 @@ def _combine_property(self, other, name, allow_duplicates=True):
             elif self_prop is not None and other_prop is None:
                 return self_prop
             else:
-                # Different non-None values - this might indicate a problem
+                # different non-None values - this might indicate a problem
+                # for cases where user intent is unclear
                 raise ValueError(
                     f"Cannot combine property '{name}': component values are different "
                     f"({self_prop} vs {other_prop}) and cannot be automatically combined"