-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FN for invalid-name
for type-annotated module constants
#9771
Draft
jacobtylerwalls
wants to merge
2
commits into
main
Choose a base branch
from
invalid-name-type-annotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
force-pushed
the
invalid-name-type-annotation
branch
2 times, most recently
from
July 7, 2024 15:47
4035baa
to
2811003
Compare
This comment has been minimized.
This comment has been minimized.
Will leave this in a failing state until we remove support for Python 3.8 in #9774. |
mbyrnepr2
previously approved these changes
Jul 8, 2024
jacobtylerwalls
force-pushed
the
invalid-name-type-annotation
branch
from
September 18, 2024 21:51
2811003
to
16c68f0
Compare
jacobtylerwalls
force-pushed
the
invalid-name-type-annotation
branch
from
September 18, 2024 22:15
16c68f0
to
692895e
Compare
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9771 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18933 18932 -1
==========================================
- Hits 18139 18138 -1
Misses 794 794
|
This comment has been minimized.
This comment has been minimized.
DO NOT MERGE -- discussion on #9770 suggests holding until 4.0 |
jacobtylerwalls
added
False Negative π¦
No message is emitted but something is wrong with the code
Breaking changes for 4.0 π¦€
labels
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking changes for 4.0 π¦€
C: invalid-name
False Negative π¦
No message is emitted but something is wrong with the code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9770