-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Pyreverse option to exclude standalone nodes #8520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pyreverse option to exclude standalone nodes #8520
Conversation
From manual test, this seems to work fine. I have no idea how the Pyreverse tests work. |
For class diagrams you can use the functional tests similar to how the regular
Unfortunately we don't have a similar concept yet for package diagrams. You can take a look at |
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8520 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 174 174
Lines 18357 18362 +5
=======================================
+ Hits 17605 17610 +5
Misses 752 752
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@DudeNr33 I keep getting a |
tests/pyreverse/test_writer.py
Outdated
no_standalone_dot_config: PyreverseConfig, get_project: GetProjectCallable | ||
) -> Iterator[None]: | ||
writer = DiagramWriter(no_standalone_dot_config) | ||
project = get_project(TEST_DATA_DIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to specify name
here like above in setup_colorized_dot
. Also you have to rename the files from no_standalone_classes.dot
to classes_no_standalone.dot
(same for package diagram).
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 80299c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for the addition! 👍
Type of Changes
Description
Closes #8476