wrong-import-order emits multiple identical messages for multiple imports on single line

[K0-RR]

Bug description

The same message is printed 5 times and isn't understandable.

Configuration

No response

Command used

pylint ./main.py

Pylint output

main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order)
main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order)
main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order)
main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order)
main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order)

Expected behavior

Only one main.py:3:0: C0411: standard import "import requests, re, signal, time, timeit, logging" should be placed before "import requests, re, signal, time, timeit, logging" (wrong-import-order) that makes sense

Pylint version

pylint 2.17.4
astroid 2.15.5
Python 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0]

OS / Environment

Pop!_OS 22.04 LTS

Additional dependencies

No response

[jacobtylerwalls]

Thanks for the great bug report. The message goes away if you alphabetize "re" before "requests". In this case with a multiple import statement I agree emitting one message is best (five messages that are clearer would be acceptable too, but probably harder to implement and less intuitive.)

[azinneck0485]

Can I work on this? I've figured out a way to possibly implement a clearer message to something like:
standard import "re" should be placed before "requests" (wrong-import-order)
if the import is import request, re

I need to refine the logic to handle the example case in the issue, where there are more than 2 imports. It's possible that this can then be leveraged to avoid repeating messages, but that will need further investigation.

[jacobtylerwalls]

Of course! Thanks for lending a hand 🤝

[Pierre-Sassoulas]

I'm not sure it's easy to do, we use isort to raise this message or not so we'd need to re-implement the logic in pylint with all the false positives that can happen if we disagree with isort. (And we could use ruff in the future instead of isort, complicating things further)

[jacobtylerwalls]

Oh I definitely agree we shouldn't reimplement isort. I just figured some light deduplication of the resulting messages was the ticket.

[azinneck0485]

After taking a look at the code, I made some changes in the strings provided to the wrong-import-message string to clarify what the message trigger. Now for the imports in the initial issue, pylint will output:

test.py:7:0: C0410: Multiple imports on one line (requests, re, signal, time, timeit, logging) (multiple-imports) test.py:7:0: C0411: standard import "re" should be placed before "requests" (wrong-import-order) test.py:7:0: C0411: standard import "signal" should be placed before "requests" (wrong-import-order) test.py:7:0: C0411: standard import "time" should be placed before "requests" (wrong-import-order) test.py:7:0: C0411: standard import "timeit" should be placed before "requests" (wrong-import-order) test.py:7:0: C0411: standard import "logging" should be placed before "requests" (wrong-import-order)

Instead of 5 identical messages, each one specifies the offending import and where it should be placed. If an import is out of order relative to several, the message ends with ...should be placed before "import1, import2" with the hope of streamlining changes needed to clear the message.

Is this along the lines of what would be expected to address this issue or should these also be consolidated in a single message (i.e., add logic to suggest the correct order of imports when on a single line) to add brevity?

[Pierre-Sassoulas]

Yes I think it's better ! There's a problem in the logic though because time should be placed after requests not before ?