Add tests for testutils.configuration_test.get_expected_output

Author: Pierre-Sassoulas

pylint/testutils/configuration_test.py

@@ -19,7 +19,9 @@
 
 
 def get_expected_or_default(
-    tested_configuration_file: str, suffix: str, default: ConfigurationValue
+    tested_configuration_file: Union[str, Path],
+    suffix: str,
+    default: ConfigurationValue,
 ) -> str:
     """Return the expected value from the file if it exists, or the given default."""
     expected = default
@@ -67,18 +69,18 @@ def get_expected_configuration(
 
 
 def get_expected_output(
-    configuration_path: str, user_specific_path: Path
+    configuration_path: Union[str, Path], user_specific_path: Path
 ) -> Tuple[int, str]:
     """Get the expected output of a functional test."""
 
     def get_related_files(
-        tested_configuration_file: str, suffix_filter: str
+        tested_configuration_file: Union[str, Path], suffix_filter: str
     ) -> List[Path]:
-        path = Path(tested_configuration_file)
+        conf_path = Path(tested_configuration_file)
         return [
             p
-            for p in path.parent.iterdir()
-            if path.stem in str(p) and str(p).endswith(suffix_filter)
+            for p in conf_path.parent.iterdir()
+            if str(p.stem).startswith(conf_path.stem) and str(p).endswith(suffix_filter)
         ]
 
     exit_code = 0

tests/testutils/data/t.3.out

@@ -0,0 +1,23 @@
+import logging
+from pathlib import Path
+
+from pytest import LogCaptureFixture
+
+from pylint.testutils.configuration_test import get_expected_output
+
+HERE = Path(__file__).parent
+USER_SPECIFIC_PATH = HERE.parent.parent
+DATA_DIRECTORY = HERE / "data"
+
+
+def test_get_expected_output(caplog: LogCaptureFixture) -> None:
+    caplog.set_level(logging.INFO)
+    exit_code, _ = get_expected_output(DATA_DIRECTORY / "t.toml", USER_SPECIFIC_PATH)
+    assert "Too much .out files" in str(caplog.text)
+    assert exit_code == -1
+    exit_code, _ = get_expected_output(DATA_DIRECTORY / "u.toml", USER_SPECIFIC_PATH)
+    assert exit_code == -1
+    assert "Wrong format for .out file name" in str(caplog.text)
+    exit_code, _ = get_expected_output(DATA_DIRECTORY / "v.toml", USER_SPECIFIC_PATH)
+    assert exit_code == 0
+    assert ".out file does not exists" in str(caplog.text)