Merge branch 'main' into tests

Author: Pierre-Sassoulas

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ on:
 
 env:
   CACHE_VERSION: 3
-  DEFAULT_PYTHON: 3.6
+  DEFAULT_PYTHON: 3.8
   PRE_COMMIT_CACHE: ~/.cache/pre-commit
 
 jobs:
@@ -509,3 +509,37 @@ jobs:
           . venv/bin/activate
           pip install -e .
           pytest -m primer_stdlib -n auto
+
+  pytest-primer-external:
+    name: Run primer tests on external libs Python ${{ matrix.python-version }} (Linux)
+    runs-on: ubuntu-latest
+    needs: prepare-tests-linux
+    strategy:
+      matrix:
+        python-version: [3.8, 3.9, "3.10"]
+    steps:
+      - name: Check out code from GitHub
+        uses: actions/checkout@v2.3.5
+      - name: Set up Python ${{ matrix.python-version }}
+        id: python
+        uses: actions/setup-python@v2.2.2
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Restore Python virtual environment
+        id: cache-venv
+        uses: actions/cache@v2.1.6
+        with:
+          path: venv
+          key:
+            ${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{
+            needs.prepare-tests-linux.outputs.python-key }}
+      - name: Fail job if Python cache restore failed
+        if: steps.cache-venv.outputs.cache-hit != 'true'
+        run: |
+          echo "Failed to restore Python venv from cache"
+          exit 1
+      - name: Run pytest
+        run: |
+          . venv/bin/activate
+          pip install -e .
+          pytest -m primer_external -n auto

.gitignore

@@ -20,3 +20,4 @@ build-stamp
 .pytest_cache/
 .mypy_cache/
 .benchmarks/
+.pylint_primer_tests/

.pre-commit-config.yaml

@@ -57,6 +57,7 @@ repos:
             "-rn",
             "-sn",
             "--rcfile=pylintrc",
+            "--fail-on=I",
             "--load-plugins=pylint.extensions.docparams",
           ]
         # disabled plugins: pylint.extensions.mccabe

ChangeLog

@@ -15,8 +15,18 @@ Release date: TBA
 
   Closes #4982
 
+* Introduced primer tests and a configuration tests framework. The helper classes available in
+  ``pylint/testutil/`` are still unstable and might be modified in the near future.
+
+  Closes #4412 #5287
+
 * Fix ``install graphiz`` message which isn't needed for puml output format.
 
+* Fix a crash in the ``check_elif`` extensions where an undetected if in a comprehension
+  with an if statement within a f-string resulted in an out of range error. The checker no
+  longer relies on counting if statements anymore and uses known if statements locations instead.
+  It should not crash on badly parsed if statements anymore.
+
 * Fix ``simplify-boolean-expression`` when condition can be inferred as False.
 
   Closes #5200
@@ -284,6 +294,12 @@ Release date: TBA
   Closes #3507
   Closes #5087
 
+* It is now recommended to do ``pylint`` development on ``Python`` 3.8 or higher. This
+  allows using the latest ``ast`` parser.
+
+* All standard jobs in the ``pylint`` CI now run on ``Python`` 3.8 by default. We still
+  support python 3.6 and 3.7 and run tests for those interpreters.
+
 * ``TypingChecker``
 
   * Fix false-negative for ``deprecated-typing-alias`` and ``consider-using-alias``

doc/development_guide/contribute.rst

@@ -64,7 +64,8 @@ You can clone Pylint and its dependencies from ::
 .. _git: https://git-scm.com/
 
 Got a change for Pylint?  Below are a few steps you should take to make sure
-your patch gets accepted.
+your patch gets accepted. We recommend using Python 3.8 or higher for development
+of Pylint as it gives you access to the latest ``ast`` parser.
 
 - Test your code
 

doc/whatsnew/2.12.rst

@@ -35,7 +35,7 @@ New checkers
 
 * Fix ``useless-super-delegation`` false positive when default keyword argument is a variable.
 
-* Added new checker `use-implicit-booleanness``: Emitted when using collection
+* Added new checker ``use-implicit-booleanness``: Emitted when using collection
   literals for boolean comparisons
 
 * Added new checker ``use-implicit-booleaness-not-comparison``: Emitted when
@@ -204,6 +204,17 @@ Other Changes
 * Added the ``--enable-all-extensions`` command line option. It will load all available extensions
   which can be listed by running ``--list-extensions``
 
+* It is now recommended to do ``pylint`` development on ``Python`` 3.8 or higher. This
+  allows using the latest ``ast`` parser.
+
+* All standard jobs in the ``pylint`` CI now run on ``Python`` 3.8 by default. We still
+  support python 3.6 and 3.7 and run tests for those interpreters.
+
 * Fix crash on ``open()`` calls when the ``mode`` argument is not a simple string.
 
   Partially closes #5321
+
+* Introduced primer tests and a configuration tests framework. The helper classes available in
+  ``pylint/testutil/`` are still unstable and might be modified in the near future.
+
+  Closes #4412 #5287

pylint/checkers/classes.py

@@ -1848,20 +1848,18 @@ def _check_first_arg_for_type(self, node, metaclass=0):
                     "bad-mcs-method-argument",
                     node.name,
                 )
-        # regular class
-        else:  # pylint: disable=else-if-used
-            # class method
-            if node.type == "classmethod" or node.name == "__class_getitem__":
-                self._check_first_arg_config(
-                    first,
-                    self.config.valid_classmethod_first_arg,
-                    node,
-                    "bad-classmethod-argument",
-                    node.name,
-                )
-            # regular method without self as argument
-            elif first != "self":
-                self.add_message("no-self-argument", node=node)
+        # regular class with class method
+        elif node.type == "classmethod" or node.name == "__class_getitem__":
+            self._check_first_arg_config(
+                first,
+                self.config.valid_classmethod_first_arg,
+                node,
+                "bad-classmethod-argument",
+                node.name,
+            )
+        # regular class with regular method without self as argument
+        elif first != "self":
+            self.add_message("no-self-argument", node=node)
 
     def _check_first_arg_config(self, first, config, node, message, method_name):
         if first not in config:

pylint/checkers/exceptions.py

@@ -232,7 +232,6 @@ def visit_const(self, node: nodes.Const) -> None:
         )
 
     def visit_instance(self, instance: objects.ExceptionInstance) -> None:
-        # pylint: disable=protected-access
         cls = instance._proxied
         self.visit_classdef(cls)
 
@@ -535,7 +534,6 @@ def visit_tryexcept(self, node: nodes.TryExcept) -> None:
                     if isinstance(exc, astroid.Instance) and utils.inherit_from_std_ex(
                         exc
                     ):
-                        # pylint: disable=protected-access
                         exc = exc._proxied
 
                     self._check_catching_non_exception(handler, exc, part)

pylint/checkers/format.py

@@ -52,7 +52,7 @@
 """
 
 import tokenize
-from functools import reduce  # pylint: disable=redefined-builtin
+from functools import reduce
 from typing import List
 
 from astroid import nodes

pylint/checkers/similar.py

@@ -26,7 +26,6 @@
 # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
 # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
 
-# pylint: disable=redefined-builtin
 """a similarities / code duplication command line tool and pylint checker
 
 The algorithm is based on comparing the hash value of n successive lines of a file.