[Backport maintenance/4.0.x] [invalid-name] Fix FP for exclusive assignment of objects (#10754)

[invalid-name] Fix FP for exclusive assignment of objects (#10746)

(cherry picked from commit d308554)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

Author: pylint-backport[bot]

custom_dict.txt

@@ -24,6 +24,7 @@ asynccontextmanager
 attr
 attrib
 attrname
+attrs
 backport
 BaseChecker
 basename
@@ -144,6 +145,7 @@ gv
 hashable
 hmac
 html
+iattrs
 idgeneratormixin
 ifexpr
 igetattr

doc/whatsnew/fragments/10745.false_positive

@@ -0,0 +1,4 @@
+Fix a false positive for ``invalid-name`` on an UPPER_CASED name inside an
+``if`` branch that assigns an object.
+
+Closes #10745

pylint/checkers/base/name_checker/checker.py

@@ -518,13 +518,12 @@ def visit_assignname(  # pylint: disable=too-many-branches,too-many-statements
                         and self._name_regexps["const"].match(node.name) is not None
                     ):
                         return
-                    if (
-                        util.Uninferable not in iattrs
-                        and len(iattrs) > 1
-                        and all(
-                            astroid.are_exclusive(*combo)
-                            for combo in itertools.combinations(iattrs, 2)
-                        )
+                    # Do the exclusive assignment analysis on attrs, not iattrs.
+                    # iattrs locations could be anywhere (inference result).
+                    attrs = tuple(node.frame().getattr(node.name))
+                    if len(attrs) > 1 and all(
+                        astroid.are_exclusive(*combo)
+                        for combo in itertools.combinations(attrs, 2)
                     ):
                         node_type = "const"
                     if not self._meets_exception_for_non_consts(

tests/functional/i/invalid/invalid_name/invalid_name_module_level.py

@@ -44,6 +44,12 @@ def A():  # [invalid-name]
     other_const = [3]
 
 
+if CONST:
+    ANOTHER_CONST = A()
+else:
+    ANOTHER_CONST = 5
+
+
 from importlib.metadata import PackageNotFoundError
 from importlib.metadata import version