Skip to content

Commit 2a41113

Browse files
Fix the Windows's bug with \r\n instead of \n
1 parent ccca0a5 commit 2a41113

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

pylint/reporters/json_reporter.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ def display_messages(self, layout):
5454
def display_reports(self, layout):
5555
output = io.StringIO()
5656
TextWriter().format(layout, output)
57-
score = output.getvalue().split("\n")[1]
58-
self.messages.append({"score": score})
57+
score = output.getvalue().split("Your")[1]
58+
score = score.split(r"/10")[0]
59+
self.messages.append({"score": "Your{}/10".format(score)})
5960

6061
def _display(self, layout):
6162
"""Do nothing."""

tests/unittest_reporters_json.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from pylint.reporters import JSONReporter
2121
from pylint.reporters.ureports.nodes import EvaluationSection
2222

23-
expected_score_message = "Expected score message"
23+
expected_score_message = "Your code has been rated at 7.50/10"
2424
expected_result = [
2525
[
2626
("column", 0),
@@ -63,7 +63,10 @@ def get_linter_result(score):
6363
linter.add_message("line-too-long", line=1, args=(1, 2))
6464
# we call those methods because we didn't actually run the checkers
6565
if score:
66-
reporter.display_reports(EvaluationSection(expected_score_message))
66+
generated_msg = "-------------------------------------\r\n{}\r\n".format(
67+
expected_score_message
68+
)
69+
reporter.display_reports(EvaluationSection(generated_msg))
6770
reporter.display_messages(None)
6871
report_result = json.loads(output.getvalue())
6972
return report_result

0 commit comments

Comments
 (0)