Skip to content

Commit b3e8974

Browse files
committed
Revert "Roll back from __future__ import annotations for Python 3.6"
This reverts commit b8ce4ad. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
1 parent 364019d commit b3e8974

File tree

5 files changed

+18
-13
lines changed

5 files changed

+18
-13
lines changed

pylint_pytest/checkers/class_attr_loader.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Optional, Set
1+
from __future__ import annotations
22

33
from astroid import Assign, Attribute, ClassDef, Name
44
from pylint.interfaces import IAstroidChecker
@@ -12,8 +12,8 @@ class ClassAttrLoader(BasePytestChecker):
1212
msgs = {"E6400": ("", "pytest-class-attr-loader", "")}
1313

1414
in_setup = False
15-
request_cls: Set[str] = set()
16-
class_node: Optional[ClassDef] = None
15+
request_cls: set[str] = set()
16+
class_node: ClassDef | None = None
1717

1818
def visit_functiondef(self, node):
1919
"""determine if a method is a class setup method"""

pylint_pytest/checkers/fixture.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
from __future__ import annotations
2+
13
import fnmatch
24
import os
35
import sys
46
from pathlib import Path
5-
from typing import Set, Tuple
67

78
import astroid
89
import pylint
@@ -21,7 +22,7 @@
2122
from .types import FixtureDict, replacement_add_message
2223

2324
# TODO: support pytest python_files configuration
24-
FILE_NAME_PATTERNS: Tuple[str, ...] = ("test_*.py", "*_test.py")
25+
FILE_NAME_PATTERNS: tuple[str, ...] = ("test_*.py", "*_test.py")
2526
ARGUMENT_ARE_KEYWORD_ONLY = (
2627
"https://docs.pytest.org/en/stable/deprecations.html#pytest-fixture-arguments-are-keyword-only"
2728
)
@@ -30,7 +31,7 @@
3031
class FixtureCollector:
3132
# Same as ``_pytest.fixtures.FixtureManager._arg2fixturedefs``.
3233
fixtures: FixtureDict = {}
33-
errors: Set[pytest.CollectReport] = set()
34+
errors: set[pytest.CollectReport] = set()
3435

3536
def pytest_sessionfinish(self, session):
3637
# pylint: disable=protected-access
@@ -79,9 +80,9 @@ class FixtureChecker(BasePytestChecker):
7980
# Store all fixtures discovered by pytest session
8081
_pytest_fixtures: FixtureDict = {}
8182
# Stores all used function arguments
82-
_invoked_with_func_args: Set[str] = set()
83+
_invoked_with_func_args: set[str] = set()
8384
# Stores all invoked fixtures through @pytest.mark.usefixture(...)
84-
_invoked_with_usefixtures: Set[str] = set()
85+
_invoked_with_usefixtures: set[str] = set()
8586
_original_add_message = replacement_add_message
8687

8788
def open(self):

pylint_pytest/checkers/types.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from __future__ import annotations
2+
13
import sys
24
from pprint import pprint
35
from typing import Any, Dict, List

tests/base_tester.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
from __future__ import annotations
2+
13
import os
24
import sys
35
from abc import ABC
46
from pprint import pprint
5-
from typing import Any, Dict, List
7+
from typing import Any
68

79
import astroid
810
from pylint.testutils import MessageTest, UnittestLinter
@@ -23,10 +25,10 @@
2325

2426
class BasePytestTester(ABC):
2527
CHECKER_CLASS = BaseChecker
26-
IMPACTED_CHECKER_CLASSES: List[BaseChecker] = []
28+
IMPACTED_CHECKER_CLASSES: list[BaseChecker] = []
2729
MSG_ID: str
28-
msgs: List[MessageTest] = []
29-
CONFIG: Dict[str, Any] = {}
30+
msgs: list[MessageTest] = []
31+
CONFIG: dict[str, Any] = {}
3032

3133
def __init_subclass__(cls, **kwargs):
3234
super().__init_subclass__(**kwargs)

tests/base_tester_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class NoMsgIDSubclass(BasePytestTester):
2020
pass
2121

2222

23-
@pytest.mark.parametrize("msg_id", [123, None, ""], ids=lambda x: f"msg_id={x}")
23+
@pytest.mark.parametrize("msg_id", [123, None, ""], ids=lambda msg_id: f"{msg_id=}")
2424
def test_init_subclass_invalid_msg_id_type(msg_id):
2525
with pytest.raises(TypeError):
2626

0 commit comments

Comments
 (0)