Skip to content

Separate string and bytes classes patching #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Separate string and bytes classes patching #807

merged 1 commit into from
Jun 23, 2020

Conversation

PCManticore
Copy link
Contributor

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

We were using the same class definition for both bytes and str, which resulted in the wrong thing being inferred when deducing x.encode() or x.decode().

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Fixes pylint-dev/pylint#3599

@PCManticore PCManticore merged commit ec96745 into master Jun 23, 2020
@PCManticore PCManticore deleted the switch-str-unicode branch June 23, 2020 06:17
brycepg pushed a commit to brycepg/astroid that referenced this pull request Jun 24, 2020
@PCManticore @brycepg
Separate string and bytes classes patching (pylint-dev#807)
2ed75d4 
Fixes pylint-dev/pylint#3599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E0308: bytes not recognized after encode
1 participant
@PCManticore