Raise when a name is inferred twice with the same context #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fact that the pandas example that crashed in the pylint primer relies on this behavior seems like a code smell. We probably should do something like the patch suggested at #2237 (comment), but that would need some more investigation to determine the best place to copy the context. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 92.83% 92.84%
=======================================
Files 94 94
Lines 10963 10964 +1
=======================================
+ Hits 10178 10179 +1
Misses 785 785
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixes #2237
Regression in 082774a. "sort of" unreleased, caused in an alpha pre-release (3.0.0a6), so no backport needed.
This was one of the fragile parts I was a little worried about when doing #2171, so I'm not surprised that it regressed.
When trying to assess if this functionality was common enough for a mixin, I was trying to work through whether
_inferand_infer_lhsreally needed the same decorators or not, and in the process I missed this decorator.