Skip to content

Add some typing to NamedTuple brain #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2022
Merged

Add some typing to NamedTuple brain #1412

merged 3 commits into from
Feb 28, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

This extracts some changes from #1306 to make that PR more reviewable.

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Feb 28, 2022
@DanielNoord DanielNoord requested a review from cdce8p February 28, 2022 10:51
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe something for 2.11.0 ?

@DanielNoord
Copy link
Collaborator Author

LGTM. Maybe something for 2.11.0 ?

No rush here. It needs to be merged before #1306 can land, but we can put this in 2.10.1 or 2.11 depending on when this gets reviewed by Marc.

cdce8p
cdce8p reviewed Feb 28, 2022
View reviewed changes
@cdce8p cdce8p added this to the 2.10.1 milestone Feb 28, 2022
DanielNoord and others added 2 commits February 28, 2022 12:33
@DanielNoord @cdce8p
Update astroid/brain/brain_namedtuple_enum.py
6c762c1 
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@cdce8p
Improve formatting - add empty line
e334806
@DanielNoord DanielNoord merged commit 841401d into pylint-dev:main Feb 28, 2022
@DanielNoord DanielNoord deleted the namedtuple-2 branch February 28, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @Pierre-Sassoulas @cdce8p