First Updates regarding the BBGUI #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoschD
added
Type: Documentation
fsoubelet
requested changes
Jun 17, 2025
Member
fsoubelet
left a comment
fsoubelet
left a comment
There was a problem hiding this comment.
Nitpicks and all, appreciate the investment!
Member
|
Also, I'm curious to see what Copilot might say so I'll summon it |
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes and updates the BBGUI documentation along with some Admin guides. Key changes include updating the mkdocs navigation structure, adding new GUI sections (Segment-by-Segment, RDT Feeddown, etc.), and introducing guidelines for GUI development and repository management.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| mkdocs.yml | Updated navigation entries and key_map modification |
| docs/packages/omc3/analysis.md | Added amplitude detuning analysis section |
| docs/packages/development/managing.md | Added a comprehensive guide to repository management |
| docs/guis/usage/guidelines.md | Introduced guidelines for GUI development |
| docs/guis/segment_by_segment/gui.md | New page for the Segment-by-Segment GUI |
| docs/guis/rdt_feeddown/gui.md | New page for the RDT Feeddown GUI |
| docs/guis/betabeat/* | Updated pages documenting various GUI components |
| docs/css/custom_colors.css | Added new CSS classes for UI enhancements |
fsoubelet
approved these changes
Jun 18, 2025
Member
fsoubelet
left a comment
fsoubelet
left a comment
There was a problem hiding this comment.
I'm happy to merge as is in the feature branch. Left just a few unresolved conversations here to help my memory on things I said I'd do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some stuff around, that still needs to be finished, but the main sites to review are (in that order):
docs/guis/betabeat
And for Admin:
The rest should be just pictures and light touches.