Skip to content

Conversation

fsoubelet
Copy link
Member

@fsoubelet fsoubelet commented May 21, 2025

This is going to be annoying to review :/

Also fixed all outdated / invalid anchor links. No more warnings in the builds.

@fsoubelet fsoubelet requested a review from JoschD May 21, 2025 21:36
@fsoubelet fsoubelet self-assigned this May 21, 2025
@fsoubelet fsoubelet added Type: Documentation Improvements, updates and fixes to the documentation. Priority: Low Work on this if you have some spare time. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Status: Review Needed Work currently stopped, untils someone else reviews it. labels May 21, 2025
@fsoubelet fsoubelet requested a review from Copilot May 21, 2025 21:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up markdown formatting, standardizes image accessibility attributes, updates link references, and converts TODOs to mkdocs-style admonitions across documentation.

  • Remove extraneous blank lines around tables and sections
  • Wrap images in <center>, add alt attributes, and adjust reference URLs to reflect doc restructuring
  • Replace inline TODOs with mkdocs admonitions and remove a deprecated guide file

Reviewed Changes

Copilot reviewed 80 out of 80 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/logbook/LHC/2022_lhc.md Removed redundant blank lines
docs/logbook/LEIR/2024_leir.md Cleaned up extra blank before the shift table
docs/logbook/LEIR/2023_leir.md Removed stray blank line
docs/logbook/AD/2024_ad.md Tidied whitespace around table and tooltips
docs/guis/usage/remote.md Wrapped figures in <center>, added alt attributes, added sshuttle reference
docs/guis/usage/releases.md Converted TODO to !!! todo admonition
docs/guis/usage/kmod_special.md Deleted deprecated KMod GUI special-features file
docs/guis/usage/ide_install.md Updated clone URL, link syntax, and reference paths
docs/guis/betabeat/settings.md Removed unnecessary whitespace
docs/guis/betabeat/plots.md Removed trailing blank line
docs/guis/betabeat/optics_panel.md Normalized markdown anchors and list formatting
docs/guis/betabeat/bpm_panel.md Added alt attributes to images and standardized TODO blocks
docs/guis/betabeat/beam_selection.md Added alt text, updated python path example, corrected omc3 link
docs/guis/betabeat/analysis_panel.md Added alt attribute to the cleaning image
docs/guis/about.md Updated link targets to mirror restructured directories
README.md Switched to python -m pip for plugin installation
Comments suppressed due to low confidence (1)

docs/guis/usage/remote.md:90

  • The link reference [sshuttle] is defined but not used in the document; consider adding a corresponding reference in the text or removing this unused definition.
[sshuttle]: https://sshuttle.readthedocs.io/en/stable/

Copy link
Member

@JoschD JoschD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof. Thanks! I did not look at everything in detail, but I scrolled through most of it at it looks like not only linting, but also a lot of bug fixing! Great job!

@fsoubelet fsoubelet merged commit f7c45a1 into user_guide_updates May 22, 2025
2 checks passed
@fsoubelet fsoubelet deleted the linting branch May 22, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Priority: Low Work on this if you have some spare time. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Documentation Improvements, updates and fixes to the documentation. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants