Skip to content

Machine settings debug logging and knobs #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2022
Merged

Machine settings debug logging and knobs #105

merged 4 commits into from
Oct 19, 2022

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Oct 19, 2022

  • No knobs by default
  • 'all' and 'default' options
  • more debug messages

@JoschD JoschD changed the title Machine settings debug logging Machine settings debug logging and knobs Oct 19, 2022
@JoschD JoschD requested a review from fsoubelet October 19, 2022 15:20
@JoschD JoschD self-assigned this Oct 19, 2022
@JoschD JoschD added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Oct 19, 2022
fsoubelet
fsoubelet reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few clarifications needed for my tired brain 😬

@JoschD JoschD requested a review from fsoubelet October 19, 2022 15:34
@JoschD JoschD merged commit 1c924c3 into master Oct 19, 2022
@JoschD JoschD deleted the machine_settings_debug_logging branch October 19, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsoubelet fsoubelet fsoubelet approved these changes

Assignees

@JoschD JoschD

Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoschD @fsoubelet