Fix lsa to madx writer #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoschD
commented
Oct 11, 2022
JoschD
commented
- LSA to MADX sign convention
- Better trim naming
- check madx names for allowed characters
- option to init all variables
- machine settings info takes ISO time
fsoubelet
reviewed
Oct 11, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
maybe we can also do a version of the test without the deferred expressions
There was a problem hiding this comment.
It doesn't test much anyway. And I don't like these tests, as you need to change the file it compares to as soon as you do any change in the code. A proper test would be running the resulting file in madx/cpymad and checking that the variables change as expected, but I don't have the time to implement this.
fsoubelet
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.