LSA knob to MAD-X script converter #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents in files, adapted from an old hacky file from Tobias
JoschD
requested changes
May 20, 2022
|
why is your diff coverage so low, with all of these tests? xD |
mihofer
reviewed
May 23, 2022
mihofer
reviewed
May 23, 2022
mihofer
reviewed
May 23, 2022
mihofer
reviewed
May 23, 2022
mihofer
reviewed
May 23, 2022
tests/inputs/lsa_to_madx/LHCBEAM_MD_ATS_2022_05_04_B1_RigidWaitsShift_IP1pos_knob.madx
Outdated
Show resolved
Hide resolved
mihofer
previously approved these changes
May 23, 2022
JoschD
reviewed
May 23, 2022
JoschD
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script which can take an
LSAknob and an optics it is defined for to create both a definition TFS file and aMAD-Xscript which will reproduce the knob in simulations.The script can also be fed a text file with many knobs definitions as well as their trim values, and run for all of these knobs. See examples in the module docstring.