Skip to content

Commit 6961e16

Browse files
committed
remove openmpi tests
1 parent 7aa952d commit 6961e16

File tree

2 files changed

+1
-47
lines changed

2 files changed

+1
-47
lines changed

.github/workflows/pipeline.yml

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -296,38 +296,6 @@ jobs:
296296
python -m unittest test_slurmclusterexecutor.py
297297
python -m unittest test_slurmjobexecutor.py
298298
299-
unittest_slurm_openmpi:
300-
needs: [black]
301-
runs-on: ubuntu-latest
302-
services:
303-
mysql:
304-
image: mysql:8.0
305-
env:
306-
MYSQL_ROOT_PASSWORD: root
307-
ports:
308-
- "8888:3306"
309-
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
310-
steps:
311-
- uses: actions/checkout@v4
312-
- uses: koesterlab/setup-slurm-action@v1
313-
- name: Conda config
314-
shell: bash -l {0}
315-
run: echo -e "channels:\n - conda-forge\n" > .condarc
316-
- uses: conda-incubator/setup-miniconda@v3
317-
with:
318-
python-version: '3.13'
319-
miniforge-version: latest
320-
condarc-file: .condarc
321-
environment-file: .ci_support/environment-openmpi.yml
322-
- name: Test
323-
shell: bash -l {0}
324-
timeout-minutes: 5
325-
run: |
326-
pip install . --no-deps --no-build-isolation
327-
cd tests
328-
python -m unittest test_slurmclusterexecutor.py
329-
python -m unittest test_slurmjobexecutor.py
330-
331299
unittest_mpich:
332300
needs: [black]
333301
runs-on: ${{ matrix.operating-system }}
@@ -464,7 +432,7 @@ jobs:
464432
GH_TOKEN: ${{secrets.GITHUB_TOKEN}}
465433

466434
uml:
467-
needs: [unittest_slurm_mpich, unittest_slurm_openmpi, unittest_old, unittest_win, unittest_openmpi, unittest_mpich, unittest_flux_openmpi, unittest_flux_mpich, notebooks, benchmark, minimal, pip_check, mypy]
435+
needs: [unittest_slurm_mpich, unittest_old, unittest_win, unittest_openmpi, unittest_mpich, unittest_flux_openmpi, unittest_flux_mpich, notebooks, benchmark, minimal, pip_check, mypy]
468436
runs-on: ubuntu-latest
469437
steps:
470438
- uses: actions/checkout@v4

tests/test_slurmjobexecutor.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def set_global():
3939
class TestSlurmBackend(unittest.TestCase):
4040
def test_slurm_executor_serial(self):
4141
with SlurmJobExecutor(
42-
max_cores=2,
4342
block_allocation=True,
4443
) as exe:
4544
fs_1 = exe.submit(calc, 1)
@@ -51,7 +50,6 @@ def test_slurm_executor_serial(self):
5150

5251
def test_slurm_executor_serial_no_depencies(self):
5352
with SlurmJobExecutor(
54-
max_cores=2,
5553
block_allocation=True,
5654
disable_dependencies=True,
5755
) as exe:
@@ -64,7 +62,6 @@ def test_slurm_executor_serial_no_depencies(self):
6462

6563
def test_slurm_executor_threads(self):
6664
with SlurmJobExecutor(
67-
max_cores=1,
6865
resource_dict={"threads_per_core": 2},
6966
block_allocation=True,
7067
) as exe:
@@ -77,7 +74,6 @@ def test_slurm_executor_threads(self):
7774

7875
def test_slurm_executor_parallel(self):
7976
with SlurmJobExecutor(
80-
max_cores=2,
8177
resource_dict={"cores": 2},
8278
block_allocation=True,
8379
) as exe:
@@ -87,7 +83,6 @@ def test_slurm_executor_parallel(self):
8783

8884
def test_single_task(self):
8985
with SlurmJobExecutor(
90-
max_cores=2,
9186
resource_dict={"cores": 2},
9287
block_allocation=True,
9388
) as p:
@@ -99,7 +94,6 @@ def test_single_task(self):
9994

10095
def test_internal_memory(self):
10196
with SlurmJobExecutor(
102-
max_cores=1,
10397
resource_dict={"cores": 1},
10498
init_function=set_global,
10599
block_allocation=True,
@@ -108,11 +102,3 @@ def test_internal_memory(self):
108102
self.assertFalse(f.done())
109103
self.assertEqual(f.result(), np.array([5]))
110104
self.assertTrue(f.done())
111-
112-
def test_validate_max_workers(self):
113-
with self.assertRaises(ValueError):
114-
SlurmJobExecutor(
115-
max_workers=10,
116-
resource_dict={"cores": 10, "threads_per_core": 10},
117-
block_allocation=True,
118-
)

0 commit comments

Comments
 (0)