Add informations on cli output about module when fact or operation was not found #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisim
commented
Nov 22, 2024
| "No such attribute in module server: NotAFact", | ||
| ( | ||
| "No such attribute in module server: NotAFact\n" | ||
| "Available facts in module are: User, Home, Path, TmpDir, Hostname, Kernel, " |
There was a problem hiding this comment.
Each update will implies an updtate of the test, maybe use a regex slould be better?
maisim
force-pushed
the
3.x_cli_show_infos_to_understand_why_op_or_fact_was_not_found
branch
2 times, most recently
from
6936791 to
fce49ad
Compare
|
It does not work as expected for operations in case of misspelling |
maisim
force-pushed
the
3.x_cli_show_infos_to_understand_why_op_or_fact_was_not_found
branch
from
fce49ad to
b89c2f4
Compare
If the operation or fact is not found, it will display the ones available, and if no one is avaible, Warn the user about the possibility that he have a py file or a folder with the same name as the module
Use of regex to avoid having to update the cli tests each time the operations and facts used in them are modified
maisim
force-pushed
the
3.x_cli_show_infos_to_understand_why_op_or_fact_was_not_found
branch
from
b89c2f4 to
8b752b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks,
If the operation or fact was not found, it will display the ones available, and if no one is available, Warn the user about the possibility that he have a py file or a folder with the same name as the module
If you have a directory wich have the same name as the pyinfra module you want to use, pyinfra will try to look inside form the operations/facts (wich seems to be the wanted behavior)
So I added a message to inform about this possibility if the module/fact is not found:
In the same time I added this:
This is a suggestion, tell me what you think.