Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 19, 2023

Resolves #63

* Use the correct model (`model_low`) for demonstration of the
  difference between the asymptotics based and toy based calculators.
   - Amends PR https://github.com/pyhf/pyhf-tutorial/pull/1
* Use 5000 pseudo-experiments to demonstrate the difference more
  effectively.
* Use underscores in numeric literals (5_000) for better readability.
   - c.f. https://peps.python.org/pep-0515/

* Use the correct model (`low_model`) for demonstration of the
  difference between the asymptotics based and toy based calculators.
   - Amends PR https://github.com/pyhf/pyhf-tutorial/pull/ 1
* Use 5000 pseudo-experiments to demonstrate the difference more
  effectively.
* Use underscores in numeric literals (5_000) for better readability.
   - c.f. https://peps.python.org/pep-0515/
Comment on lines +139 to +140
" [5.0, 7.0] + model_low.config.auxdata,\n",
" model_low,\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just above this is

model_low = pyhf.simplemodels.uncorrelated_background(
    signal=[0.5, 1.0], bkg=[5.0, 6.0], bkg_uncertainty=[0.5, 1.2]
)

but we were never using this model_low for some reason and so were trying to fit a model that terribly modeled the observations to begin with. This PR just used the model we meant to.

@matthewfeickert matthewfeickert requested a review from kratsg August 19, 2023 06:19
@kratsg kratsg merged commit d752f15 into main Aug 24, 2023
@kratsg kratsg deleted the fix/get-toys-working branch August 24, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pseudo-experiments notebook is giving nans

3 participants