Update rubocop requirement from ~> 0.81.0 to ~> 1.28.2 (#248)

* Update rubocop requirement from ~> 0.81.0 to ~> 1.28.2

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.81.0...v1.28.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Enable all new Rubocop rules

* Fix Rubocop warnings

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marat Radchenko <marat@slonopotamus.org>

Author: dependabot[bot]

.rubocop.yml

@@ -1,5 +1,8 @@
 AllCops:
+  NewCops: enable
   TargetRubyVersion: 2.5
+Gemspec/RequireMFA:
+  Enabled: false
 Metrics/AbcSize:
   Enabled: false
 Metrics/BlockLength:
@@ -12,6 +15,8 @@ Layout/LineLength:
   Max: 120
 Metrics/MethodLength:
   Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
 Style/StructInheritance:
   Enabled: false
 Style/Documentation:

bench.rb

@@ -9,7 +9,7 @@
 # we can also repeat the code itself
 repeats = ARGV[1] ? ARGV[1].to_i : 1
 
-code = File.open('test/test_pygments.rb').read.to_s * repeats
+code = File.read('test/test_pygments.rb') * repeats
 
 puts "Benchmarking....\n"
 puts "Size: #{code.bytesize} bytes\n"

lib/pygments/popen.rb

@@ -17,7 +17,7 @@ class Popen
     # Python process that talks to the Pygments library. We'll talk back and
     # forth across this pipe.
     def start(pygments_path = File.join(__dir__, '..', '..', 'vendor', 'pygments-main'))
-      @log = Logger.new(ENV['MENTOS_LOG'] || File::NULL)
+      @log = Logger.new(ENV.fetch('MENTOS_LOG', File::NULL))
       @log.level = Logger::INFO
       @log.datetime_format = '%Y-%m-%d %H:%M '
 
@@ -323,11 +323,7 @@ def write_header(header, code)
     def get_timeout(timeout)
       return timeout unless timeout.nil?
 
-      begin
-        Integer(ENV['MENTOS_TIMEOUT'])
-      rescue TypeError
-        0
-      end
+      Integer(ENV.fetch('MENTOS_TIMEOUT', 0))
     end
 
     # Based on the header we receive, determine if we need

pygments.rb.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.5.0'
 
   s.add_development_dependency 'rake', '~> 13.0.0'
-  s.add_development_dependency 'rubocop', '~> 0.81.0'
+  s.add_development_dependency 'rubocop', '~> 1.28.2'
   s.add_development_dependency 'test-unit', '~> 3.5.0'
 
   s.files = `git ls-files -z`.split("\0").reject { |f| File.symlink?(f) }