add type hints for properties #703
Draft
+99
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipitis
commented
Apr 10, 2025
| } | ||
| name = pythonmap.get(name, name) | ||
|
|
||
| # Is this a case for which we need to recurse? | ||
| if name.startswith("sequence<") and name.endswith(">"): | ||
| if (name.startswith("sequence<") or name.startswith("FrozenArray<")) and name.endswith(">"): |
There was a problem hiding this comment.
the spec says this is not a sequence type: https://webidl.spec.whatwg.org/#idl-frozen-array but I believe in python it's list either way. Plus is is currently just used for GPUCompilationInfo which is unimplemented in wgpu-native
Vipitis
commented
Apr 10, 2025
| @@ -11,7 +11,10 @@ | |||
| ### Patching API for _classes.py | |||
| * Diffs for GPU: add enumerate_adapters_async, add enumerate_adapters_sync, change get_preferred_canvas_format, change request_adapter_async, change request_adapter_sync | |||
| * Diffs for GPUCanvasContext: add get_preferred_format, add present | |||
| * Error resolving type for GPUAdapter.limits: ('Encountered unknown IDL type: ', 'SupportedLimits') | |||
There was a problem hiding this comment.
the situation for Limits sounds more complex: gpuweb/gpuweb#4277
But I guess it will be set, maybe list eventually. We can also just not annotate it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #697
goal is to add type annotations to properties in
_classes.pyvia codegen.A lot of properties resolve to simple
intorstrpython types while others are enums.Will look into expanding
resolve_typewhere it's needed or find better workarounds for features/limits. I am not 100% sure how type hints get inherited from these stubs, as there have been changes every single python release.