Add return type hints #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally I'd say don't bother, but for an API like this I like the explicitness. |
|
I think this should be good mostly. please have a look as some of the edge cases feel hacky as usual. Will look into adding typing for properties/attributes (I think also the args to some of the constructors like |
almarklein
reviewed
Apr 8, 2025
Korijn
approved these changes
Apr 8, 2025
|
There are merge conflicts ! |
|
ah, got to rebase and likely rerun codegen. But will probably only get to that later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #696
found where the type hints can be added in codegen, had to work through a bunch of edge cases. Will see if these cases can be added to already existing utils.
also not sure if
-> Noneis really wanted everywhere.still in progress... hopefully I can get this done early next week.
as for the 2nd question in the issue, I looked through some ideas with stub classes in mypy, .pyi files and even using
if "TYPE_CHECKING"to import the autobackend. But doesn't feel like that solves the issue if having the "go to declaration" button go to the implementation - I might keep this an option issue.