Improve generated type hints and defaults #606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegen
that produces the method signatures is improved:Optional[..]
if needed.optional
keyword in idl into account.None
as a default value in cases where it should not.check_struct()
in a few more places, because the above fixes made the checker detect more cases.depth_stencil
arg increate_render_pipeline()
. It's odd that IDL makes that field mandatory, because it means one cannot create a render pipeline without a depth-stencil attachment? We will have to look into this deeper when we implement the JS backend. It could well be an oversight in the IDL.