Skip to content

Remove controller.c from gitignore #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Remove controller.c from gitignore #3418

merged 1 commit into from
Apr 28, 2025

Conversation

MightyJosip
Copy link
Member

controller.c is not cython generated file (?) so it shouldn't be ignored by git

@MightyJosip
Remove controller.c from gitignore
0cc489e 
controller.c is not cython generated file (?) so it shouldn't be ignored by git
@MightyJosip MightyJosip requested a review from a team as a code owner April 28, 2025 10:11
ankith26
ankith26 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, just checked the source and yes controller.c does exist in there. Thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.4 milestone Apr 28, 2025
@damusss damusss added the Code quality/robustness Code quality and resilience to changes label Apr 28, 2025
damusss
damusss approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damusss damusss merged commit 0510571 into main Apr 28, 2025
1 check passed
@damusss damusss deleted the gitignore branch April 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MightyJosip @ankith26 @damusss