Include tutorials docs in release build (fixes #3353) #3380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damusss
changed the title
|
Just curious, what is the wheel size change after this PR? |
Probably around 1.16 MB. I'm not a fan of this, but it's true that we technically did save enough space to "afford" it. You should chat with Starbuck about wether it's worth adding it or not. |
|
In my testing it is not 1.16 MB, it is 227 KB. That is today's main vs this branch (wheel files). Maybe you were not accounting for the fact that wheels are zip files, so text is compressed inside them. Where as with images it's more 1-to-1 because they're already compressed. |
damusss
changed the title
ankith26
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did as the title says as sturbuck requested in #3353 (comment), fixing #3353.