Skip to content

Port camera to SDL3 #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2025
Merged

Port camera to SDL3 #3341

merged 1 commit into from
Feb 22, 2025

Conversation

ankith26
Copy link
Member

camera now fully compiles on SDL3

@ankith26 ankith26 requested a review from a team as a code owner February 20, 2025 07:01
@Starbuck5 Starbuck5 added sdl3 camera pygame.camera labels Feb 22, 2025
Starbuck5
Starbuck5 approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Eventually I think we will replace a lot of this with SDL3's new camera system, but it's nice to have it compiling regardless.

damusss
damusss approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting, looks good :)

@damusss damusss added this to the 2.5.4 milestone Feb 22, 2025
@damusss damusss merged commit a05d084 into main Feb 22, 2025
25 checks passed
@ankith26 ankith26 deleted the ankith26-camera-sdl3 branch February 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
camera pygame.camera sdl3
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ankith26 @Starbuck5 @damusss