Skip to content

Prep surface_fill.c for SDL3 #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

Starbuck5
Copy link
Member

Putting this one out as a simple PR, hopefully straightforward to review.

It brings some of the SDL3 compat macros that have been developed in previous PRs into the surface_fill.c's sphere of influence. To get surface_fill.c to fully compile I additionally had to mess with the GET_PIXELVALS macros, which I have not included in this PR because I am keeping it simple and because I am waiting to reunify them with the macros I split out in #3309.

@Starbuck5 Starbuck5 added Surface pygame.Surface sdl3 labels Feb 19, 2025
@Starbuck5 Starbuck5 requested a review from a team as a code owner February 19, 2025 07:12
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything makes sense, LGTM, thanks 👍

@damusss damusss added this to the 2.5.4 milestone Feb 19, 2025
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🥳

@damusss damusss merged commit e84b4be into pygame-community:main Feb 19, 2025
25 checks passed
@Starbuck5 Starbuck5 deleted the surface-fill-sdl3-prep branch February 20, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdl3 Surface pygame.Surface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants