General improvements and fixes to stubs #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
Feb 15, 2025
MightyJosip
reviewed
Feb 17, 2025
damusss
approved these changes
Feb 19, 2025
damusss
added
type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of general fixes to stubs.
Especially, making some attributes that seemed to be read-only when I tested, read-only.
Plus minor corrections, internal renaming.
Notes:
It seems that stubtest didn't catch the incorrect return type of
sndarray.use_arraytype()even thoughsndarrayis a python module.I found that
midi.Input.device_idwas undocumented. Alsomidi.__theclasses__, an unused variable.There are 2 other larger stub issues that I will address in later PRs.