Modification in draw.rect #3229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: test.txt
Member
|
A more relevant open PR addressing this issue would be #3158 |
added 2 commits
November 27, 2024 14:12
…attributes of a rect, in rect_tests.py
Member
|
This branch (a main branch) now seems to have a selection of random changes smooshed together, and we also already have a PR tackling this subject so I'm closing it. @Neri19 feel free to jump onto the other PR on this topic if you want to help get that one over the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the function rect in draw.c to call the function draw_round_rect with a radius positive or 0 to resolve issues with negative radii. In fact, in the doc, the radius can't be negative.
We can choose to raise an exception but i don't think that it's necessary.
Related to #2285
I don't know if it has been fixed by #2303